Skip to content

Commit

Permalink
episode 2 - fix readme
Browse files Browse the repository at this point in the history
  • Loading branch information
davidcallanan authored Jan 20, 2021
1 parent 31bc853 commit 1510c69
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ This respository holds all the source code for [this YouTube tutorial series](ht

You can find the revision for a specific episode on [this page](https://github.com/davidcallanan/yt-os-series/tags).

You can find pre-built ISO files for this kernel at [this repository](https://github.com/davidcallanan/os-series-isos).

Considering supporting this work via [my Patreon page](http://patreon.com/codepulse).

## Prerequisites
Expand All @@ -21,7 +23,8 @@ Build an image for our build-environment:
## Build

Enter build environment:
- Linux or MacOS: `docker run --rm -it -v "$pwd":/root/env myos-buildenv`
- Linux: `docker run --rm -it -v "$pwd":/root/env myos-buildenv`
- MacOS: `docker run --rm -it -v "$PWD":/root/env myos-buildenv`
- Windows (CMD): `docker run --rm -it -v "%cd%":/root/env myos-buildenv`
- Windows (PowerShell): `docker run --rm -it -v "${pwd}:/root/env" myos-buildenv`
- NOTE: If you are having trouble with an unshared drive, ensure your docker daemon has access to the drive you're development environment is in. For Docker Desktop, this is in "Settings > Shared Drives" or "Settings > Resources > File Sharing".
Expand Down

2 comments on commit 1510c69

@bckelley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 27 should read MacOS or Linux as that worked on my linux machine

@davidcallanan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for opening an issue.

This is the way I had it before, but I believe there are certain scenarios on MacOS where PWD needs to be in uppercase. I can't remember the reasoning behind it and where I read it, but it seems to have solved problems for many of viewers on YouTube.

I'll leave this distinction between linux and mac in place until I am confident that there is a single command that works on both systems.

Please sign in to comment.