Ability to define keys and segment for split_definition.treatment (#125)

api/split_definition.go

@@ -52,8 +52,8 @@ type Treatment struct {
 	Name           *string  `json:"name"`
 	Configurations *string  `json:"configurations"`
 	Description    *string  `json:"description"`
-	Keys           *string  `json:"keys,omitempty"`
-	Segment        []string `json:"segment,omitempty"`
+	Keys           []string `json:"keys,omitempty"`
+	Segments       []string `json:"segments,omitempty"`
 }
 
 // Bucket represents a sticky distribution of customers into treatments of a Split.

docs/resources/split_definition.md

@@ -96,6 +96,8 @@ explain the difference between each treatment. This attribute block supports the
 * `configurations` - (Required) `<string>` Dynamically configure components of your feature (e.g. A button's color or backend API pagination).
   This attribute's value must be a valid JSON string.
 * `description` - (Optional) `<string>` Description of the treatment.
+* `keys` - (Optional) `<list(string)>` List of target key ids.
+* `segments` - (Optional) `<list(string)>` List of segments.
 
 ### `default_rule`
 

split/resource_split_split_definition.go

@@ -80,6 +80,22 @@ func resourceSplitSplitDefinition() *schema.Resource {
 							Optional: true,
 							Computed: true,
 						},
+
+						"keys": {
+							Type: schema.TypeSet,
+							Elem: &schema.Schema{
+								Type: schema.TypeString,
+							},
+							Optional: true,
+						},
+
+						"segments": {
+							Type: schema.TypeSet,
+							Elem: &schema.Schema{
+								Type: schema.TypeString,
+							},
+							Optional: true,
+						},
 					},
 				},
 			},
@@ -375,6 +391,24 @@ func constructSplitDefinitionRequestOpts(d *schema.ResourceData) (*api.SplitDefi
 				t.Description = &v
 			}
 
+			if v, ok := vt["keys"]; ok {
+				vL := v.(*schema.Set).List()
+				keys := make([]string, 0)
+				for _, e := range vL {
+					keys = append(keys, e.(string))
+				}
+				t.Keys = keys
+			}
+
+			if v, ok := vt["segments"]; ok {
+				vL := v.(*schema.Set).List()
+				segments := make([]string, 0)
+				for _, e := range vL {
+					segments = append(segments, e.(string))
+				}
+				t.Segments = segments
+			}
+
 			treatments = append(treatments, t)
 		}
 
@@ -484,9 +518,23 @@ func constructSplitDefinitionRequestOpts(d *schema.ResourceData) (*api.SplitDefi
 }
 
 func setTreatmentInState(d *schema.ResourceData, sd *api.SplitDefinition) {
-	treatments := make([]map[string]string, 0)
+	treatments := make([]map[string]interface{}, 0)
 	for _, t := range sd.Treatments {
-		treatments = append(treatments, map[string]string{
+		treatment := map[string]interface{}{
+			"name":           t.GetName(),
+			"configurations": t.GetConfigurations(),
+			"description":    t.GetDescription(),
+		}
+
+		if t.HasKeys() {
+			treatment["keys"] = t.Keys
+		}
+
+		if t.HasSegments() {
+			treatment["segments"] = t.Segments
+		}
+
+		treatments = append(treatments, map[string]interface{}{
 			"name":           t.GetName(),
 			"configurations": t.GetConfigurations(),
 			"description":    t.GetDescription(),