Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: record unparsed lines instead of skipping them #7

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

davidjrice
Copy link
Owner

@davidjrice davidjrice commented Apr 11, 2024

  • Improved performance 🔥 by extracting the record identifier before attempting to call a parse method on a given line
  • Raises an UnidentifiedRecordError if an unidentified record is found
  • Enables keeping track of unparsed lines and returns them in the resultant data hash as result[:unparsed]

…g the record_identifier before parse

* negates the need for looping over methods, improving performance
* allows tracking of unparsed lines and returns then in the result hash as :unparsed
@davidjrice davidjrice merged commit 96d77c1 into master Apr 12, 2024
4 checks passed
@davidjrice davidjrice deleted the djr/unparsed branch April 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant