-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest V3 Support #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use new storage utils that interface with `chrome.storage.sync` directly - Use an in-memory page cache to support jQuery, etc. (`window.PAGE_CACHE`)
davidofwatkins
force-pushed
the
manifest-v3
branch
from
July 1, 2024 08:29
a936e6c
to
575bf13
Compare
davidofwatkins
force-pushed
the
manifest-v3
branch
from
July 7, 2024 20:36
575bf13
to
b7ce21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the extension to support Manifest V3, soon to be required by Google.
Many of the changes here follow Google's migration guide, but a large part of complexity comes from no longer having access to
localStorage
in the background page (now a service worker). Instead, the extension writes to and reads fromchrome.storage.sync
directly, rather than syncing that withlocalStorage
on change.