Skip to content

Commit

Permalink
Merge pull request ostreedev#3287 from cgwalters/fix-memleak
Browse files Browse the repository at this point in the history
lib/traverse: Fix minor memory leak
  • Loading branch information
ericcurtin authored Sep 7, 2024
2 parents 413b0ad + bd5b4ad commit 81867f0
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/libostree/ostree-repo-traverse.c
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,13 @@ parents_get_commits (GHashTable *parents_ht, GVariant *object, GHashTable *res)
char **
ostree_repo_traverse_parents_get_commits (GHashTable *parents, GVariant *object)
{
g_autoptr (GHashTable) res = g_hash_table_new (g_str_hash, g_str_equal);
g_autoptr (GHashTable) res = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL);

parents_get_commits (parents, object, res);

return (char **)g_hash_table_get_keys_as_array (res, NULL);
// TODO: Once we can depend on modern glib 2.76, just use g_hash_table_steal_all_keys
g_autofree char **tmpbuf = (char **)g_hash_table_get_keys_as_array (res, NULL);
return g_strdupv (tmpbuf);
}

static gboolean traverse_dirtree (OstreeRepo *repo, const char *checksum, GVariant *parent_key,
Expand Down

0 comments on commit 81867f0

Please sign in to comment.