Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render relation in case of we hit partition limits #403

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: render relation in case of we hit partition limits #403

merged 1 commit into from
Sep 7, 2023

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Sep 7, 2023

Description

Small fix to put the actual relation in the logging.

Before fix

{{ relation }} with many partitions created

After fix

 '"awsdatacatalog"."dbt_nicola"."test_partitions" with many partitions created';

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 added the enable-functional-tests Label to trigger functional testing label Sep 7, 2023
@svdimchenko
Copy link
Contributor

nice catch 💯

@nicor88 nicor88 merged commit abbc69a into main Sep 7, 2023
10 checks passed
@nicor88 nicor88 deleted the fix/improve_logging branch September 7, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svdimchenko svdimchenko svdimchenko approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@Jrmyy Jrmyy Awaiting requested review from Jrmyy

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

Assignees
No one assigned
Labels
enable-functional-tests Label to trigger functional testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicor88 @svdimchenko