Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #741

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Drop support for Python 3.8 #741

merged 4 commits into from
Oct 17, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 16, 2024 •
edited
Loading

Problem

Python 3.8 reached end of life on 10/7/2024.

Solution

Drop support for Python 3.8. Update tests to no longer run on Python 3.8.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare requested a review from a team as a code owner October 16, 2024 23:18
@mikealfare mikealfare changed the title rop support for python 3.8 Drop support for Python 3.8 Oct 16, 2024
@mikealfare mikealfare self-assigned this Oct 16, 2024
@mikealfare
Merge branch 'main' into remove-py38-support
f74247b 
# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/functional-tests-workflow.yml
#	CONTRIBUTING.md
#	setup.py
@mikealfare mikealfare enabled auto-merge (squash) October 17, 2024 19:46
@mikealfare mikealfare merged commit 5fb9bf8 into main Oct 17, 2024
13 checks passed
@mikealfare mikealfare deleted the remove-py38-support branch October 17, 2024 19:48
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 2, 2024
Merged
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt