Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid tmp table name when using: unique_tmp_table_suffix #754

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

atommych
Copy link
Contributor

@atommych atommych commented Nov 8, 2024

Description

When using unique_tmp_table_suffix=True, the UUID added generated contain dashes which causes the following error:
mismatched input '-'. Expecting: '(', '.', 'AS', 'COMMENT', 'WITH'

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@atommych atommych requested a review from a team as a code owner November 8, 2024 16:05
@atommych atommych changed the title remove dashes from ´__dbt_tmp´ suffix Invalid tmp table name when using: unique_tmp_table_suffix Nov 8, 2024
@nicor88
Copy link
Contributor

nicor88 commented Nov 9, 2024

@atommych could you have a look at the interagration tests? They might need to be readapted

@nicor88
Copy link
Contributor

nicor88 commented Nov 20, 2024

@atommych any plan to fix the integration tests? I believe that this regex must be re-adapted to omit the -, also if it's easier, we could consider to use replace('-','_') then in the regex for the integration tests we can simply replace the - with _. Using _ in the table name is still valid.

@atommych
Copy link
Contributor Author

Hi @nicor88 , I will work on it till Friday! Thanks for the tips

@atommych
Copy link
Contributor Author

Hi @nicor88, the integration test are good now!

@nicor88
Copy link
Contributor

nicor88 commented Nov 23, 2024

@colin-rogers-dbt and @mikealfare could you please have a look? this looks good to be merged.

@atommych update your branch with main then we are ready to go.

@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) November 23, 2024 19:19
@colin-rogers-dbt colin-rogers-dbt merged commit a425cc6 into dbt-labs:main Nov 23, 2024
11 checks passed
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 2, 2024
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants