Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move upper bounds back to 2.0 #11024

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Move upper bounds back to 2.0 #11024

merged 5 commits into from
Nov 21, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 21, 2024

Problem

The upper bound pin of dbt-common and dbt-adapters is causing adapters to pick up the wrong, older version, of dbt-core.

Solution

Open the pin of dbt-common and dbt-adapters back up to 2.0 on 1.8.latest.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (3a1c605) to head (4c98df3).
Report is 1 commits behind head on 1.8.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #11024      +/-   ##
==============================================
- Coverage       88.33%   88.27%   -0.06%     
==============================================
  Files             181      181              
  Lines           22796    22796              
==============================================
- Hits            20136    20123      -13     
- Misses           2660     2673      +13     
Flag Coverage Δ
integration 85.45% <ø> (-0.14%) ⬇️
unit 62.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@emmyoop emmyoop marked this pull request as ready for review November 21, 2024 19:30
@emmyoop emmyoop requested a review from a team as a code owner November 21, 2024 19:30
@emmyoop emmyoop merged commit 1d9c536 into 1.8.latest Nov 21, 2024
52 checks passed
@emmyoop emmyoop deleted the er/unpin-18 branch November 21, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants