Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-jobs: document temp schema macro limitation #4187

Merged
merged 5 commits into from
Oct 6, 2023
Merged

ci-jobs: document temp schema macro limitation #4187

merged 5 commits into from
Oct 6, 2023

Conversation

aaronraff
Copy link
Contributor

What are you changing in this pull request and why?

Converts the "Temporary schemas aren't dropping" section into a list of items. The first item remains the same, but a new item was added to note that schemas will not be dropped unless they were written to as a result of running a dbt model.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@aaronraff
ci-jobs: document temp schema macro limitation
07b58a0 
Converts the "Temporary schemas aren't dropping" section into a list of
items. The first item remains the same, but a new item was added to note
that schemas will not be dropped unless they were written to as a result
of running a dbt model.
@welcome
Copy link

welcome bot commented Oct 4, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:18pm

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Oct 4, 2023
@aaronraff aaronraff marked this pull request as ready for review October 4, 2023 21:33
@aaronraff aaronraff requested a review from a team as a code owner October 4, 2023 21:33
@aaronraff aaronraff requested a review from nghi-ly October 4, 2023 21:33
nghi-ly
nghi-ly approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nghi-ly nghi-ly merged commit 0fa8b1b into current Oct 6, 2023
7 checks passed
@nghi-ly nghi-ly deleted the aaronraff/schema-dropping-macro-limitation branch October 6, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronraff @nghi-ly