Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update execute.md #5198

Merged
merged 11 commits into from
Apr 10, 2024
Merged

Update execute.md #5198

merged 11 commits into from
Apr 10, 2024

Conversation

ialdg
Copy link
Contributor

@ialdg ialdg commented Apr 1, 2024

Hi.
This modification proposal has two points:
1- Add a comment suggesting that it'd a good idea to add line numbers to a particular piece of coding (although it'd be great for all pieces of coding present in the docs), to make easier the task for the reader. 2- Make a piece of coding more elegant and less demanding on the warehouse. Regards.
IL.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Hi.
This modification proposal has two points:
1- Add a comment suggesting that it'd a good idea to add line numbers to a particular piece of coding (although it'd be great for all pieces of coding present in the docs), to make easier the task for the reader.
2- Make a piece of coding more elegant and less demanding on the warehouse.
Regards.
IL.
@ialdg ialdg requested a review from a team as a code owner April 1, 2024 06:12
Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Apr 10, 2024 2:19pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Apr 1, 2024
@mirnawong1 mirnawong1 self-assigned this Apr 5, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Apr 10, 2024

{# Return the first column #}
{% set payment_methods = results.columns[0].values() %}
1 {% set payment_method_query %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely agree @ialdg with you, added line numbers here for ease. thanks for that sugg!

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1 mirnawong1 enabled auto-merge April 10, 2024 14:05
@mirnawong1 mirnawong1 disabled auto-merge April 10, 2024 14:05
@mirnawong1 mirnawong1 enabled auto-merge April 10, 2024 14:06
@mirnawong1 mirnawong1 merged commit 7a82e76 into dbt-labs:current Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants