Fixing Examples #5206
Merged
Fixing Examples #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
runleonarun
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Hey @matthewshaver I know you wanted to get the crucial examples, but it might be more confusing if we don't change all examples at least on a page.
I suggest we clean up these pages completely then chip away at other config and setup pages. What do you think?
runleonarun
approved these changes
Apr 3, 2024
| @@ -30,7 +30,7 @@ dbt-hive supports two transport mechanisms: | |||
| - binary | |||
| - HTTP(S) | |||
|
|
|||
| The default mechanism is `binary`. To use HTTP transport, use the boolean option `use_http_transport: [true / false]`. | |||
| The default mechanism is `binary`. To use HTTP transport, use the boolean option. For example, `use_http_transport: true`. | |||
There was a problem hiding this comment.
@matthewshaver I changed this to be an example for clarity.
| Compute2: | ||
| http_path:[`/some/other/path'] | ||
| http_path: /SOME/OTHER/PATH | ||
|
|
||
| ``` | ||
|
|
There was a problem hiding this comment.
I noticed the profile.yml Under Selecting compute per model also uses the <profile-name> but maybe we should change all profile.yml and project.yml examples in one PR to reduce confusion. what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Removing brackets from a few examples as they tend to cause confusion.
Also updated some placeholder text to match our style guide for examples
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.jswebsite/vercel.jsonnpm run buildto update the links that point to deleted pages