Fix heading and links for loaded_at_field
#5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
dbeatty10
commented
Apr 2, 2024
| (Required) | ||
| </VersionBlock> | ||
| A column name (or expression) that returns a timestamp indicating freshness. | ||
|
|
||
| <br/><br/>A column name (or expression) that returns a timestamp indicating freshness. |
There was a problem hiding this comment.
Adding the <br/><br/> tags is a little ugly, but it's the only thing I found that would work to preserve the current formatting.
I tried several things to no avail.
If we don't like them, I'd suggest that we merge this PR as-is and create a follow-up to address them.
mirnawong1
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
lgtm and i believe this may be related to a potential bug that i reported to the front end team here.
i had another pr where i did something similar to what you did here in order to solve this until it's permanently fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview 1.6
Preview 1.7
What are you changing in this pull request and why?
The changes in this PR fix the following two issues:
There are two links on the sidebar for
loaded_at_field:Another issue is that links to the
#loaded_at_fieldanchor tag won't always go where you intend, depending on the version the user has selected. I believe this has the same root cause as the first issue.🎩
After
1.6 before
1.6 after
1.7 before
1.7 after
Checklist