Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining multiple primary_key constraints at the column level is not supported #5210

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

will-sargent-dbtlabs
Copy link
Contributor

@will-sargent-dbtlabs will-sargent-dbtlabs commented Apr 2, 2024

What are you changing in this pull request and why?

Revises the verbiage based on a recent conversation with the core team, where multiple column-level primary key constraints actually fails silently in 1.7, but will generate a warning in 1.8 as unsupported.

We are not clear about this today in docs, leading to potential confusion and technical debt for users on older versions.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@will-sargent-dbtlabs will-sargent-dbtlabs requested a review from a team as a code owner April 2, 2024 14:33
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 9:41am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Apr 2, 2024
@dbeatty10
Copy link
Contributor

See dbt-labs/dbt-bigquery#1016 (comment) where a user ran into this (and here where we responded with an example).

@dbeatty10 dbeatty10 changed the title Update constraints.md Defining multiple primary_key constraints at the column level is not supported Apr 2, 2024
@mirnawong1 mirnawong1 enabled auto-merge April 4, 2024 09:28
@mirnawong1 mirnawong1 merged commit c62cc0a into current Apr 4, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the will-sargent-dbtlabs-patch-1 branch April 4, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants