Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated last of images #6572

Closed
wants to merge 12 commits into from
Closed

Updated last of images #6572

wants to merge 12 commits into from

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Dec 2, 2024

What are you changing in this pull request and why?

I've created this PR to update the last of images on UI

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

Sorry, something went wrong.

@nataliefiann nataliefiann requested a review from a team as a code owner December 2, 2024 13:45
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 11, 2024 11:13am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 2, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a hover notification is showing in this screenshot. It may distract from what we're trying to highlight here. It might help to point an arrow or put a box around the defer toggle

@@ -49,7 +49,7 @@ You can clone nodes between states in dbt Cloud using the `dbt clone` command. T

- Set up your **Production environment** and have a successful job run.
- Enable **Defer to production** by toggling the switch in the lower-right corner of the command bar.
<Lightbox src="/img/docs/dbt-cloud/defer-toggle.jpg" width="80%" title="Select the 'Defer to production' toggle on the bottom right of the command bar to enable defer in the dbt Cloud IDE."/>
<Lightbox src="/img/docs/dbt-cloud/defer-toggle.png" width="200%" title="Select the 'Defer to production' toggle on the bottom right of the command bar to enable defer in the dbt Cloud IDE."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still see the hover notification and i also recommend tidying up the red box around the defer toggle as it looks a little misaligned.
Screenshot 2024-12-09 at 11 16 17

also, what is the difference between this new image and the current img?

Screenshot 2024-12-09 at 11 16 55

@@ -83,7 +83,7 @@ If you change the value of an environment variable mid-session while using the I

To refresh the IDE mid-development, click on either the green 'ready' signal or the red 'compilation error' message at the bottom right corner of the IDE. A new modal will pop up, and you should select the Refresh IDE button. This will load your environment variables values into your development environment.

<Lightbox src="/img/docs/dbt-cloud/using-dbt-cloud/Environment Variables/refresh-ide.gif" title="Refreshing IDE mid-session"/>
<Lightbox src="/img/docs/dbt-cloud/using-dbt-cloud/Environment Variables/refresh-ide.png" title="Refreshing IDE mid-session"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming this image is being replaced by the pr here: https://github.com/dbt-labs/docs.getdbt.com/pull/6634/files right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Yep, that's right. Thanks for reviewing this for me.

Kind Regards
Natalie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants