Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP6963 #32

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add EIP6963 #32

merged 1 commit into from
Jan 10, 2024

Conversation

SebastienGllmt
Copy link
Contributor

Fix #31

This should make WSC work even in cases where other wallets the user has installed tries to avoid writing to the window.ethereum value

@SebastienGllmt SebastienGllmt requested a review from nicarq January 10, 2024 13:13
@SebastienGllmt SebastienGllmt merged commit 2716a51 into main Jan 10, 2024
3 checks passed
@SebastienGllmt SebastienGllmt deleted the eip-6963-support branch January 10, 2024 17:01
MartinOndejka
MartinOndejka reviewed Jan 10, 2024
View reviewed changes
Copy link

@MartinOndejka MartinOndejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinOndejka MartinOndejka MartinOndejka left review comments

@nicarq nicarq Awaiting requested review from nicarq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement EIP6963
2 participants
@SebastienGllmt @MartinOndejka