Update selenium image to 124.0 #42
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously used image was about two years old and contains Chromium version 101.
|
Hanging, just like it did at #31. i dont know the cause. |
|
Thanks. I only search in open PRs for duplication |
|
I think Selenium dropped compatibility with the JSON wire protocol a while back, but supporting the W3C dialect is still a WIP: https://www.drupal.org/project/drupal/issues/3432099. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The plugin uses a selenium docker image, which is about two years old and contains outdated Chromium version 101
How This PR Solves The Issue
This PR switches to a newer docker image with Chromium version 124. I also thought about using "latest" instead of a specific version. But I decided against it, because this would mean, the users always would use and pull new images with other Chromium versions which would result in unexpected behavior.
Manual Testing Instructions
Update the current plugin in your DDEV settings and execute
ddev restart. This will trigger to pull the newer image.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes