Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drupal 10.3 failures, fixes #41, fixes #46 #48

Closed
wants to merge 1 commit into from

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 3, 2024

The Issue

This is @andriokha 's recommended fix from

I'm baffled why he didn't present it as a PR, but here it is, showing co-author.

It seems to solve the test problem

Fixes

Manual testing:

ddev get https://github.com/rfay/ddev-selenium-standalone-chrome/tarball/20240703_andriokha_fix_drupal_10.3

@rfay
Copy link
Member Author

rfay commented Jul 3, 2024

And tests are green. Manual testing recommended of course.

ddev get https://github.com/rfay/ddev-selenium-standalone-chrome/tarball/20240703_andriokha_fix_drupal_10.3

@andriokha
Copy link
Contributor

Thanks @rfay! As mentioned in #41 (comment) I wasn't sure if the problem was best fixed by a change here or in lullabot/php-webdriver. As of today there's an open PR against the latter, so it might be worth holding off merging this in until that's resolved (if it gets merged in, we shouldn't need any change to this, and this will carry on working with older versions of Drupal as well).

@andriokha
Copy link
Contributor

Note that PR's been merged now, so hopefully the tests will start running green without any changes required and we can close this.

@rfay
Copy link
Member Author

rfay commented Jul 4, 2024

@rfay rfay closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants