Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post: Astro dev with DDEV article #116

Conversation

bmartinez287
Copy link
Collaborator

The Issue

This PR adds a new article to ddev.com. It highlights how to add ddev support to an astro site such as ddev.com.

Note

I tried pushing this branch to ddev.com but it gave an authentication error. I will try with some other changes later and see if I need to change my settings to do that and allow the Cloudfare previews.

@bmartinez287 bmartinez287 marked this pull request as draft October 15, 2023 21:58
@rfay
Copy link
Member

rfay commented Oct 27, 2023

Move to "ready for review" when it is, thanks!

@bmartinez287
Copy link
Collaborator Author

Sounds good, I was waiting for #111 to go in first as my example for it.

@rfay rfay force-pushed the 20231013_bmartinez287_ddevonastrosite_blogpost branch from 0e5e371 to bc2f6a8 Compare November 8, 2023 17:17
@rfay
Copy link
Member

rfay commented Nov 8, 2023

Now this one is live, thanks for your patience. Rebased.

@bmartinez287
Copy link
Collaborator Author

I will do a final editorial round and add maybe another tip or two and set it for review.

@rfay
Copy link
Member

rfay commented Nov 28, 2023

Let me know when ready.

@bmartinez287 bmartinez287 marked this pull request as ready for review November 29, 2023 01:21
@bmartinez287
Copy link
Collaborator Author

@rfay it's ready for review.

@rfay rfay force-pushed the 20231013_bmartinez287_ddevonastrosite_blogpost branch from 5c0b6bc to a11edee Compare November 29, 2023 22:39
@rfay
Copy link
Member

rfay commented Nov 29, 2023

Rebased.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate all your work in making this work, and I've used your DDEV setup without trouble in the last few articles I've written!

Unfortunately, this lacks focus at this point and can't be published. You need to come up with one thing that the article is about and focus on that. I think it's about how to work on ddev.com using DDEV. If that's what it is, zero in on that and simplify it and remember that most people won't read very many paragraphs.

You might consider asking ChatGPT or another chatbot like claude.ai for coaching on it as well, or if you have a person that can help, that's cool too.

If you'd like to do a separate article on Astro and DDEV, with simple general instructions for setting that up, that would be welcome as well, but needs clear focus and needs to be simple enough that people will keep reading.

Thanks so much for all your work on this site and the using-DDEV contribution in the first place, and thanks for this. It has a future, but has to be much simplified.

---
name: Bernardo Martinez
firstName: Bernardo
avatarUrl: https://2.gravatar.com/avatar/2798cb634ac4f9c15d702b5a35417dbd8faffad84b7afe0b3d8143d9b076b042??s=96&d=mm&r=g
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use local avatar, I guess that's preferred.

src/content/authors/bernardo-martinez.md Outdated Show resolved Hide resolved
@@ -0,0 +1,103 @@
---
title: "Astro development with DDEV"
pubDate: 2023-11-30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pubDate: 2023-11-30
pubDate: 2023-12-01

Maybe :) But we're going to get it!

src/content/blog/astro-development-with-ddev.md Outdated Show resolved Hide resolved

DDEV.com is an [Astro](https://astro.build/) website. Astro is fantastic tool that packed with features that provide a low-entry barrier for developers looking to contribute features, issues and more. Among it's highlights are its low hosting cost, file-based routing, and extensive Markdown support.

That said, for a while this website did not use DDEV. Adding DDEV makes it easier for those with the tool to contribute PRs, but also provides an example on how other projects can take advantage of it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear what we're talking about here. Strengthen this paragraph.

src/content/blog/astro-development-with-ddev.md Outdated Show resolved Hide resolved

As of this article, there are two ways to setup your local development on DDEV.com. With DDEV and without DDEV. Whichever is easier and more convenient for you.

This guide will highlight what was required to add DDEV to an Astro project. It's meant to provide you with some background as well as tips along the way. That said, feel free to look at this [website](https://github.com/ddev/ddev.com/blob/main/.ddev/config.yaml) config first and reverse engineer your approach if that's easier.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the article is about how to use DDEV with Astro, it would be better to just add a step-by-step at the end saying how. People don't need to look at the config.yaml though.


The instructions below assume you have DDEV and Docker installed and globally available.

## 1. Run `ddev config`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the local preview to see that this isn't working out - you can't use ## 1. in both these places, doesn't do anything.


## 1. Vite in DDEV

There are a couple of ways one could run Vite in DDEV.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just say what you did, don't talk about a couple of ways.

@bmartinez287
Copy link
Collaborator Author

Sounds good, I didn't think I could get two blogs out of this one but that's a great observation. I will look into the tips above.

@rfay rfay marked this pull request as draft January 30, 2024 21:02
@rfay
Copy link
Member

rfay commented Jan 30, 2024

Thanks for taking this up again! I've put it in draft mode, let me know when it's ready for another review.

@bmartinez287 bmartinez287 force-pushed the 20231013_bmartinez287_ddevonastrosite_blogpost branch from 23f95e4 to c7bd8e4 Compare February 19, 2024 21:50
@bmartinez287 bmartinez287 changed the title Add Astro dev with DDEV article Blog: Astro dev with DDEV article Feb 19, 2024
@bmartinez287 bmartinez287 changed the title Blog: Astro dev with DDEV article Blog post: Astro dev with DDEV article Feb 19, 2024
@bmartinez287 bmartinez287 requested a review from rfay February 19, 2024 21:52
@bmartinez287 bmartinez287 marked this pull request as ready for review February 19, 2024 21:52
@bmartinez287
Copy link
Collaborator Author

@rfay its ready for another pass.

@bmartinez287
Copy link
Collaborator Author

Probably needs an update after recent changes so I will change to draft for now.

@bmartinez287 bmartinez287 marked this pull request as draft March 15, 2024 19:49
@tyler36
Copy link
Contributor

tyler36 commented Oct 25, 2024

Is this still being worked on?

@bmartinez287
Copy link
Collaborator Author

Great question. So much work was put into the Vite article that this is probably redundant.
I probably close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants