Fixes DDEV search component. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8590de9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a0a48f19.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://20231120-bmartinez287-ddev-p.ddev-com-front-end.pages.dev |
|
After looking at a few alternatives such as creating a constant, or saving the domain on the search.json file this seemed to be the quickest and potentially the most elegant fix. @rfay |
rfay
approved these changes
Nov 21, 2023
|
I will merge it in since it's already broken, but if you have a suggestion for a fix that's a bit better let us know. @mattstein. I think it originally worked because it made some assumptions that the recent major upgrade took away. |
|
OK, sounds like a plan. We can go back to it if Matt has a better idea. |
bmartinez287
deleted the
20231120_bmartinez287_ddev_pr_fix_search_component
branch
|
Oof, thanks for fixing this @bmartinez287 and sorry I broke it! |
|
No worries, thanks for keeping the project up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The issue is described here
How This PR Solves The Issue
It adds the domain to the javascript search utility.