-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update working-with-vite-in-ddev.md #237
Conversation
@mandrasch thanks for the article, and your review is what matters, thanks. |
Hi @dingman, thanks for suggestion and PR! 👍 Please implement the following changes:
Reasoning, why I'm not a fan of this, at least for a beginner's tutorial - because web daemons can make things harder for newbies, quote from discussion on Discord:
From my point of view it is an expert topic. With a disclaimer and in a extra section, this is fine in my opinion - and a great addition to the article. 👍 @rfay I have no real time resources till end of month (summer time 🌞 ), feel free to merge this in any way it seems fitting to you. The article should be helpful for the whole DDEV community and not just be my personal opinion piece (of course). ;) I could re-check at end of August as well to see if I have further change proposals. |
Looking forward to getting back to this when you've had a chance to look at the suggestions @dingman and when you get back @mandrasch |
@dingman What about something like this? (new chapter in the article) Automatically start ViteThere is also the possibility to automatically start Vite when you start a DDEV project. Please beware: Autostart can complicate things a bit, it's a technique for advanced usage. Some developers like having it run in a background daemon, others like putting it in the post-start hook. That way it runs automatically, but the output & errors are still visible in the terminal. If you want to run Vite in the background as a daemon via web_extra_daemons, edit your config.yaml like this ("ddev restart" needed):
Errors are only visible via "ddev logs" if you run Vite as daemon. An example can be found here as well: https://github.com/ddev/ddev.com You can also use supervisors like pm2 (https://www.lullabot.com/articles/nodejs-development-ddev) |
Sadly, I haven't had time to prioritize making this update. Your update looks great and I give it a +1 |
You'd probably want to update and push the change @dingman I'll close this about November 1, 2024 if it doesn't make progress. Thanks for taking the time to contribute on this, but we need to get to the finish line. |
Added language to start vite as a daemon
Rebased. |
hey, I'll bring it over the finish line 🏁 thanks for reminder! |
Created #255 |
Thanks for the initiative, fixed in |
Added language to start vite as a daemon
The Issue
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes