Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README for new contributors #265

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Improve README for new contributors #265

merged 1 commit into from
Oct 25, 2024

Conversation

mandrasch
Copy link
Collaborator

The Issue

How This PR Solves The Issue

  • add info
  • add info for troubleshooting

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! It does prompt you on ddev start to know what URL to use, and it also shows it in ddev describe. I usually end up using ddev describe a few times. We should probably add an extra launcher custom command or something.

@rfay rfay merged commit 0631d64 into ddev:main Oct 25, 2024
1 check passed
@mandrasch
Copy link
Collaborator Author

mandrasch commented Oct 25, 2024

Looks good to me, thanks! It does prompt you on ddev start to know what URL to use, and it also shows it in ddev describe. I usually end up using ddev describe a few times. We should probably add an extra launcher custom command or something.

Sure thing 👍

Yeah, I saw the prompt ... but then switched terminals and used ddev launch because I forgot --> this only renders dist/ (also a bit confusing maybe, why a page is suddenly showing up there, because in the beginning there is 403 forbidden)

From my personal experience, ddev describe is often unknown or people forget about it (unfortunately). Always trying to educate them of course. :-D

But these are just small things, motivated people won't be stopped by them of course. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants