-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove expired sponsors from sponsors list #273
Conversation
Deploying ddev-com-front-end with Cloudflare Pages
|
url | ||
avatarUrl | ||
} | ||
user: user(login: "rfay") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure we want to change the user here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we had the ddev
org, some people had started sponsoring the project via the rfay
account. This was also accounted for previously in the code here, but the logic was different. There are still 17 people and orgs sponsoring DDEV via the rfay account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared
https://ddev.com/resources/featured-sponsors.svg
https://20241108-remove-not-current.ddev-com-front-end.pages.dev//resources/featured-sponsors.svg
It's okay to have it arranged like this?
I'm not clear about what part of the arrangement you're talking about, thanks for looking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it was a rectangle, and now it's a trapezoid 🙂
I'm fine with it.
Okay, thanks, I just checked how it would look at https://github.com/ddev/ddev |
The Issue
We've been showing long-since expired github sponsors and featured sponsors, and that's not fair to the folks that are currently active.
How This PR Solves The Issue
Manual Testing Instructions
Review the results on the rendered home page
Rendered
It won't show up on https://github.com/ddev/ddev yet of course, but that should be the same.