Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expired sponsors from sponsors list #273

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Nov 8, 2024

The Issue

We've been showing long-since expired github sponsors and featured sponsors, and that's not fair to the folks that are currently active.

How This PR Solves The Issue

  • Remove inactive featured sponsors
  • Remove inactive github sponsors

Manual Testing Instructions

Review the results on the rendered home page

Rendered

It won't show up on https://github.com/ddev/ddev yet of course, but that should be the same.

Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2024

Deploying ddev-com-front-end with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2600bc7
Status: ✅  Deploy successful!
Preview URL: https://db4091f3.ddev-com-front-end.pages.dev
Branch Preview URL: https://20241108-remove-not-current.ddev-com-front-end.pages.dev

View logs

@rfay rfay requested review from bmartinez287 and stasadev November 9, 2024 00:28
@rfay rfay marked this pull request as ready for review November 9, 2024 00:29
url
avatarUrl
}
user: user(login: "rfay") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure we want to change the user here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we had the ddev org, some people had started sponsoring the project via the rfay account. This was also accounted for previously in the code here, but the logic was different. There are still 17 people and orgs sponsoring DDEV via the rfay account.

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfay
Copy link
Member Author

rfay commented Nov 11, 2024

I'm not clear about what part of the arrangement you're talking about, thanks for looking.

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it was a rectangle, and now it's a trapezoid 🙂

I'm fine with it.

@rfay
Copy link
Member Author

rfay commented Nov 11, 2024

I think it looks OK,
image

Everything I've been doing here has been just prompting AI, since I don't understand most of what goes on :(

@stasadev
Copy link
Member

Okay, thanks, I just checked how it would look at https://github.com/ddev/ddev

@rfay rfay merged commit 1676416 into main Nov 11, 2024
2 checks passed
@rfay rfay deleted the 20241108_remove_not_current_sponsors branch November 11, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants