Add "leading sponsor" setup to sponsors display, fixes #44 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ddev-com-front-end with
|
| Latest commit: |
7cd973f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d809440.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://20241108-add-leading-sponsor.ddev-com-front-end.pages.dev |
stasadev
requested changes
Nov 11, 2024
There was a problem hiding this comment.
https://20241108-add-leading-sponsor.ddev-com-front-end.pages.dev/#supporters
Light, I see the horizontal line:
Dark, I don't see the horizontal line (if it matters):
Testing the direct link with
Light (good):
https://20241108-add-leading-sponsor.ddev-com-front-end.pages.dev/resources/featured-sponsors.svg
Dark (shows nothing for me):
rfay
force-pushed
the
20241108_add_leading_sponsor_setup
branch
from
3874298 to
9ef7802
Compare
|
|
Co-authored-by: Bernardo Martinez <[email protected]>
|
OK, trying it out, thanks! |
bmartinez287
approved these changes
Nov 12, 2024
stasadev
requested changes
Nov 12, 2024
Co-authored-by: Stanislav Zhuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Platform.sh and future "lead sponsors" want a more prominent listing.
Review at https://20241108-add-leading-sponsor.ddev-com-front-end.pages.dev/#supporters
Manual Testing Instructions
Review the main page in regular and dark mode.