-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the hero wider so it does not look tiny on larger screens and other minor fixes #276
base: main
Are you sure you want to change the base?
Conversation
… with the footer and provides more space to the hero.
What is a hero? You're a hero! |
A hero is usually what you call that first section where the title and the terminal animation play on the homepage |
I'm thinking about changing the hero layout but that likely be a different PR. |
I note that it's pretty terrible on phone. Thanks for paying attention, sorry for the distraction! |
OK to merge when you are ready, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I was going for what Tailwindcss and a few others do but it can be refined for sure. |
It's 2560x1080. |
I think Tailwind has a different layout, because the logo is not clickable (it's one page site). |
I guess we should close this if it doesn't have a future? |
Do we know what inspired the current design? Was there Figma or something like it involved or not? I might close this issue and take another angle at it. Initially, I was going to make the changes incrementally. However, that is challenging as the current design makes some assumptions. I could start with the interior pages that need work, but we could revamp the homepage and make that carry throughout. Plus with Astro 5 released 2 days ago and tailwind4 coming in it be nice for a refresh. thoughts? interior pages or homepage redesign? |
@mattstein knows :) |
Not sure how much help it is, but I cobbled things together roughly looking at Tailwind UI and trying to approximate the previous version of the site without any radical departures. Nothing ever touched Figma because I just started noodling with it wondering what an update might look like and not originally intending to run with it. My aim was to keep a similar, consistent column that the previous site used and I only broke out of it slightly on the homepage for a bit more rhythm and breathing room. The hero graphic/animation was meant to peek out from the side and give a whiff of what DDEV looks like in action rather than be a prominent feature, but that admittedly gets awkward with a wide viewport. No strong feelings about what this PR is doing, I only wonder what the implications are for the rest of the site since it does conform more strictly to a single, tall column. (And also what browser dimensions are most common, which could directly inform decisions here.) |
Thanks for the feedback Matt! I can relate, "just started noodling" been there done that haha. |
It makes the hero wider so it does not look tiny on larger screens, like the footer, and provides more space to the hero.
The Issue
Before this PR
After this PR.
This is mostly to improve how the site looks on larger screens.
Review at https://20241011-bmartinez-header-fo.ddev-com-front-end.pages.dev/