Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about ddev-vitest #280

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

tyler36
Copy link
Contributor

@tyler36 tyler36 commented Nov 28, 2024

The Issue

I recently released the ddev-vitest add-on.

Vitest is a vite-native testing framework, as a alterantive/succssor to Jest. It even re-uses the same vite.config.js file.

Not sure if you want to include this vite-adjacent addon. A percentage of Vite users are also likely to use Vitest, so I include it for "complete-ness"

Please close if you feel it's outside the original scope.

How This PR Solves The Issue

This PR does the following:

  • removes trailing spaces
  • adds note & link to ddev-vitest addon.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@tyler36
Copy link
Contributor Author

tyler36 commented Nov 29, 2024

@mandrasch tagging you because the PR is against your blog post.

@mandrasch
Copy link
Collaborator

mandrasch commented Nov 29, 2024

hi @tyler36 - "removes trailing spaces" - just out of curiosity:

did you use prettier and editorconfig for formatting in visual studio code? I thought I ran formatting last time I pushed changes, but can't remember - maybe I didn't and we just discussed it in the last PR.
Would be helpful if that would be added as PR check here automatically (prettier . --check). Also noticed that trim_trailing_whitespace = false is set to false in .editorconfig. 🤔

Nice that vitest has a DDEV addon now, great work! 👏

@mandrasch
Copy link
Collaborator

Update: Autoformatting was only discussed in this PR, but no action taken so far - #268 (comment)

@rfay
Copy link
Member

rfay commented Dec 1, 2024

@mandrasch when/if you approve this I'll pull.

@mandrasch
Copy link
Collaborator

@rfay I approve 👍

@rfay rfay merged commit aae7c57 into ddev:main Dec 1, 2024
1 check passed
@tyler36
Copy link
Contributor Author

tyler36 commented Dec 2, 2024

did you use prettier and editorconfig for formatting in visual studio code?

VSCode has a setting "files.trimTrailingWhitespace": true, that I have set globally, but I usually have prettier running on save too. Not sure which setting caught the spaces when I was making the PR though.

@mandrasch
Copy link
Collaborator

mandrasch commented Dec 2, 2024

@tyler36 good to know!

Prettier parses .editorconfig, and overrides with .prettierrc https://prettier.io/docs/en/configuration.html#editorconfig

I have both extensions installed:

Don't know what the current state is - if editorconfig extension is needed as well or if prettier extension alone is sufficient in VScode.

I can check again after pulling the latest changes if I whitespaces re-appear when I auto-format via prettier extension. And we could generally think about a PR to get the formatting back on track in this repo + add a auto check for PRs.

@tyler36 tyler36 deleted the 20241128-ddev-vitest branch December 6, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants