-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about ddev-vitest #280
Conversation
@mandrasch tagging you because the PR is against your blog post. |
hi @tyler36 - "removes trailing spaces" - just out of curiosity: did you use prettier and editorconfig for formatting in visual studio code? I thought I ran formatting last time I pushed changes, but can't remember - maybe I didn't and we just discussed it in the last PR. Nice that vitest has a DDEV addon now, great work! 👏 |
Update: Autoformatting was only discussed in this PR, but no action taken so far - #268 (comment) |
@mandrasch when/if you approve this I'll pull. |
@rfay I approve 👍 |
VSCode has a setting |
@tyler36 good to know! Prettier parses I have both extensions installed:
Don't know what the current state is - if editorconfig extension is needed as well or if prettier extension alone is sufficient in VScode. I can check again after pulling the latest changes if I whitespaces re-appear when I auto-format via prettier extension. And we could generally think about a PR to get the formatting back on track in this repo + add a auto check for PRs. |
The Issue
I recently released the ddev-vitest add-on.
Vitest is a vite-native testing framework, as a alterantive/succssor to Jest. It even re-uses the same vite.config.js file.
Not sure if you want to include this vite-adjacent addon. A percentage of Vite users are also likely to use Vitest, so I include it for "complete-ness"
Please close if you feel it's outside the original scope.
How This PR Solves The Issue
This PR does the following:
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes