Auto-format files with prettier, add vscode settings, fixes #281 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ddev-com-front-end with
|
| Latest commit: |
53eab7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89ff5026.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://pr-format-prettier.ddev-com-front-end.pages.dev |
rfay
changed the title
|
Thanks! A quick look around on https://pr-format-prettier.ddev-com-front-end.pages.dev/ didn't show trouble. |
|
I briefly checked some blog posts and didn't notice any errors/bug as well. Good to go from my side 👍 |
|
https://8c9417f6.ddev-com-front-end.pages.dev//resources/featured-sponsors-darkmode.svg Those 3 seems to be working as expected and I did not find any glaring issues while browsing around. It's all good from my side. |
bmartinez287
approved these changes
Dec 5, 2024
stasadev
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thank you @mandrasch !
I only found one small formatting problem.
src/content/blog/maintaining-ddev-tests-contributor-training.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Stanislav Zhuk <[email protected]>
|
Let's see how we do with this. Thanks @mandrasch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
.vscode/settings.jsonand.vscode/extensions.jsonto gitnpx prettier --write .to auto-format all filesnpx prettier --check .) to test.yml to block wrongly formatted PRs in futureManual Testing Instructions
Review rendered at https://pr-format-prettier.ddev-com-front-end.pages.dev/
Automated Testing Overview
Maybe use https://ddev.com/blog/ddev-diffy-introduction/ for visual comparison? haven't had time for that yet. https://github.com/garris/BackstopJS is an open source alternative
Related Issue Link(s)
Release/Deployment Notes