Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of changes, so I expect merge is unlikely, but I'd like to throw my 2 cents here.
STDERR replaced with proper PSR logger, errors with exceptions, and lot of code cleanup using modern static analysis and code style tools.
There is still some work to be done to make the code fully typed, but my intention was to accommodate this code to be used with modern Symfony apps as a library. As for future tasks, removing the
false
return type would also make the code cleaner, so would be a separation between service layer and data layer. Reducing the functions complexity would be nice too.I'd love to have some unit tests here, as I'm not an expert on PDF. Manual tests with the signing functionality I needed are working as previously.