refactor: keep full string and quotations

decaf-dev · Dec 26, 2023 · d28c961 · d28c961
1 parent 9898ca8
commit d28c961
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/commands/export-into-multiple-notes/index.ts b/src/commands/export-into-multiple-notes/index.ts
@@ -2,7 +2,7 @@ import { App, Command, Notice } from "obsidian";
 import { exportBrowserTabs } from "src/export/export";
 import { createFile, createFolder } from "src/utils/file-utils";
 import { getFrontmatterForFile } from "src/utils/frontmatter-utils";
-import { appendWebsiteTitle, findLongestString, getWebsiteTitle, removeQuotations, removeTrailingPeriod, removeWebsiteTitles, trimForObsidian } from "src/utils/title-utils";
+import { appendWebsiteTitle, getWebsiteTitle, removeTrailingHyphen, removeTrailingPeriod, removeWebsiteTitles, trimForObsidian } from "src/utils/title-utils";
 import { PluginSettings } from "src/types";
 import { pipeline } from "src/utils/pipeline";
 import { formatForFileSystem } from "src/utils/file-system-utils";
@@ -33,8 +33,8 @@ const callback = (app: App, settings: PluginSettings) => async () => {
 		for (const tab of tabs) {
 			const { title, url } = tab;
 
-			const titlePipeline = pipeline(formatForFileSystem, removeQuotations, removeWebsiteTitles, findLongestString, removeTrailingPeriod);
-			const titleString = titlePipeline(title);
+			const titlePipeline = pipeline(formatForFileSystem, removeWebsiteTitles, removeTrailingHyphen, removeTrailingPeriod);
+			const titleString = (titlePipeline(title) as string).trim();
 
 			const websiteTitle = getWebsiteTitle(url);
 			const trimmed = trimForObsidian(titleString as string, websiteTitle, "md");

diff --git a/src/utils/title-utils.ts b/src/utils/title-utils.ts
@@ -28,6 +28,10 @@ export const removeWebsiteTitles = (value: string) => {
 	return value;
 }
 
+export const removeTrailingHyphen = (value: string) => {
+	return value.replace(/-$/, "");
+}
+
 /**
  * Finds the longest string in a string that is separated by a hyphen space `- ` or space hyphen ` -`
  * @param value - The value to format