Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close the sell collection modal when setting the store as minter #3232

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

LautaroPetaccio
Copy link
Contributor

This PR fixes a couple of small bugs, but the most important is that it fixes the experience of setting the store as minter, which was not closing the modal.

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 7:18pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12538052250

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 48.896%

Totals Coverage Status
Change from base Build 12431402891: 0.003%
Covered Lines: 5978
Relevant Lines: 11245

💛 - Coveralls

Copy link
Contributor

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LautaroPetaccio LautaroPetaccio merged commit 6ab0cc6 into master Jan 2, 2025
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/close-sell-collection-modal branch January 2, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants