chore: notify finish proposal job errors

decentraland · Sep 21, 2023 · 0662146 · 0662146
1 parent 71af0ae
commit 0662146
Showing 1 changed file with 31 additions and 27 deletions.
diff --git a/src/entities/Proposal/jobs.ts b/src/entities/Proposal/jobs.ts
@@ -203,35 +203,39 @@ async function categorizeProposals(
 }
 
 export async function finishProposal(context: JobContext) {
-  const finishableProposals = await ProposalModel.getFinishableProposals()
-  if (finishableProposals.length === 0) {
-    return
-  }
+  try {
+    const finishableProposals = await ProposalModel.getFinishableProposals()
+    if (finishableProposals.length === 0) {
+      return
+    }
 
-  const currentBudgets = await BudgetService.getBudgetsForProposals(finishableProposals)
-
-  context.log(`Updating ${finishableProposals.length} proposals...`)
-  const { finishedProposals, acceptedProposals, outOfBudgetProposals, rejectedProposals, updatedBudgets } =
-    await categorizeProposals(finishableProposals, currentBudgets, context)
-
-  await updateFinishedProposals(finishedProposals, context)
-  await updateAcceptedProposals(acceptedProposals, context)
-  await updateOutOfBudgetProposals(outOfBudgetProposals, context)
-  await updateRejectedProposals(rejectedProposals, context)
-  await BudgetService.updateBudgets(updatedBudgets)
-
-  const proposals = [...finishedProposals, ...acceptedProposals, ...rejectedProposals]
-  context.log(`Updating ${proposals.length} proposals in discourse... \n\n`)
-  for (const { id, title, winnerChoice, outcomeStatus } of proposals) {
-    ProposalService.commentProposalUpdateInDiscourse(id)
-    if (outcomeStatus) {
-      DiscordService.finishProposal(
-        id,
-        title,
-        outcomeStatus,
-        outcomeStatus === ProposalOutcome.FINISHED ? winnerChoice : undefined
-      )
+    const currentBudgets = await BudgetService.getBudgetsForProposals(finishableProposals)
+
+    context.log(`Updating ${finishableProposals.length} proposals...`)
+    const { finishedProposals, acceptedProposals, outOfBudgetProposals, rejectedProposals, updatedBudgets } =
+      await categorizeProposals(finishableProposals, currentBudgets, context)
+
+    await updateFinishedProposals(finishedProposals, context)
+    await updateAcceptedProposals(acceptedProposals, context)
+    await updateOutOfBudgetProposals(outOfBudgetProposals, context)
+    await updateRejectedProposals(rejectedProposals, context)
+    await BudgetService.updateBudgets(updatedBudgets)
+
+    const proposals = [...finishedProposals, ...acceptedProposals, ...rejectedProposals]
+    context.log(`Updating ${proposals.length} proposals in discourse... \n\n`)
+    for (const { id, title, winnerChoice, outcomeStatus } of proposals) {
+      ProposalService.commentProposalUpdateInDiscourse(id)
+      if (outcomeStatus) {
+        DiscordService.finishProposal(
+          id,
+          title,
+          outcomeStatus,
+          outcomeStatus === ProposalOutcome.FINISHED ? winnerChoice : undefined
+        )
+      }
     }
+  } catch (error) {
+    ErrorService.report('Error finishing proposals', { error, category: ErrorCategory.Job })
   }
 }