refactor: return validated required string

decentraland · Sep 14, 2023 · acbd496 · acbd496
1 parent b880a79
commit acbd496
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/back/routes/badges.ts b/src/back/routes/badges.ts
@@ -103,9 +103,7 @@ async function createBadgeSpec(req: WithAuth): Promise<BadgeCreationResult> {
   const user = req.auth
   validateDebugAddress(user)
 
-  const { badgeCid } = req.body
-  validateRequiredString('badgeCid', badgeCid)
-
+  const badgeCid = validateRequiredString('badgeCid', req.body.badgeCid)
   try {
     const result = await createSpec(badgeCid)
     return { status: ActionStatus.Success, badgeCid: JSON.stringify(result) }

diff --git a/src/back/utils/validations.ts b/src/back/utils/validations.ts
@@ -83,6 +83,7 @@ export function validateRequiredString(fieldName: string, value?: string) {
   if (!value || value.length === 0) {
     throw new RequestError(`Invalid ${fieldName}`, RequestError.BadRequest)
   }
+  return value
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any