fix: activity ticker filter button not working on network change (#1678)

decentraland · Feb 22, 2024 · d9e1b42 · d9e1b42
1 parent 6fcda45
commit d9e1b42
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/components/Home/ActivityTickerFilter.css b/src/components/Home/ActivityTickerFilter.css
@@ -1,4 +1,8 @@
 .ActivityTickerFilter {
+  z-index: 1;
+}
+
+.ActivityTickerFilter__ButtonContainer {
   height: 18px;
   flex-shrink: 0;
   display: flex;

diff --git a/src/components/Home/ActivityTickerFilter.tsx b/src/components/Home/ActivityTickerFilter.tsx
@@ -67,11 +67,15 @@ export default function ActivityTickerFilter({ onApply, filterState }: Props) {
     setCheckedFilters((prev) => ({ ...prev, [filterClicked]: !prev[filterClicked] }))
   }
 
-  useClickOutside('.ActivityTickerFilterBox', isOpen, () => setIsOpen(false))
+  useClickOutside('.ActivityTickerFilter', isOpen, () => setIsOpen(false))
 
   return (
-    <>
-      <div className={classNames('ActivityTickerFilter')} onMouseDown={() => setIsOpen(!isOpen)}>
+    <div className="ActivityTickerFilter">
+      <div
+        role="button"
+        className="ActivityTickerFilter__ButtonContainer"
+        onClick={() => setIsOpen((prevState) => !prevState)}
+      >
         {selectedFiltersCount !== 0 && <Counter count={selectedFiltersCount} size="small" />}
         <div
           className={classNames(
@@ -122,6 +126,6 @@ export default function ActivityTickerFilter({ onApply, filterState }: Props) {
           </div>
         </div>
       )}
-    </>
+    </div>
   )
 }