-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate push notifications sdk #1233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyesp
force-pushed
the
feat/notifications-push
branch
from
September 19, 2023 14:26
8402af9
to
8ec5694
Compare
ncomerci
approved these changes
Oct 10, 2023
1emu
approved these changes
Oct 10, 2023
type: 'TEXT', | ||
notNull: true, | ||
}, | ||
last_notification_id: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be handy to have the created-at/updated_at for debug purposes.
For example, if at some point the service stop working or whatevs, we could know which where the last updated, or since when it stopped working, etc
ncomerci
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #854
Integration
UI
Notifications
Trigger: A member of the DAO Committee mark a passed Grant proposal as enacted by adding a Vesting Contract
Target recipient: Author / Coauthors of the Grant Proposal
Copy: Title: "Grant Proposal Enacted"
Description: "Congratulations! Your Grant Proposal has been successfully enacted and a Vesting Contract was added"
Target URL: Grant Proposal URL
Type: Grants
Trigger: A proposal got published and the user has been added as a coauthor.
Target recipient: Proposed co author
Copy: Title: "Co-author Request Received"
Description: "You've been invited to collaborate as a co-author on a published proposal. Accept it or reject it here"
Target URL: Proposal URL
Type: Proposals
Trigger: A proposal ended
Target recipient: Authors & Co authors of the proposal
Copy: Title: "Voting Ended on Your Proposal [TITLE]"
Description: "The votes are in! Find out the outcome of the voting on your proposal now."
Target URL: Proposal URL
Type: Proposals
Trigger: A proposal ended
Target recipient: Users who voted on the proposal
Copy: Title: "Voting Ended on a Proposal You Voted On"
Description: "Discover the results of the proposal you participated in as a voter. Your input matters!"
Target URL: Proposal URL
Type: Proposals
Trigger: Governance Squad released a new feature
Target recipient: Users of the DAO
Copy: TBD
Target URL: Customized by Governance Squad
Type: Announcements