Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate push notifications sdk #1233

Merged
merged 54 commits into from
Oct 20, 2023
Merged

Conversation

andyesp
Copy link
Member

@andyesp andyesp commented Sep 4, 2023

Closes #854

Integration

  • Add notification type to metadata sent to Push ("Done" but need further explanation from the Push team about the integration)
  • Markdown. (Markdown implemented in our custom notification item component but Push frontend is not supporting markdown even if the documentation says it's supported)

UI

  • Notifications list
  • Integrate notification category icons
  • Signature state
  • Opt out
  • Subscription state
  • Empty state
  • Signature pending state

Notifications

  • Contract Enacted
    Trigger: A member of the DAO Committee mark a passed Grant proposal as enacted by adding a Vesting Contract
    Target recipient: Author / Coauthors of the Grant Proposal
    Copy: Title: "Grant Proposal Enacted"
    Description: "Congratulations! Your Grant Proposal has been successfully enacted and a Vesting Contract was added"
    Target URL: Grant Proposal URL
    Type: Grants
  • Co-author Request Received
    Trigger: A proposal got published and the user has been added as a coauthor.
    Target recipient: Proposed co author
    Copy: Title: "Co-author Request Received"
    Description: "You've been invited to collaborate as a co-author on a published proposal. Accept it or reject it here"
    Target URL: Proposal URL
    Type: Proposals
  • Voting Ended (Authors)
    Trigger: A proposal ended
    Target recipient: Authors & Co authors of the proposal
    Copy: Title: "Voting Ended on Your Proposal [TITLE]"
    Description: "The votes are in! Find out the outcome of the voting on your proposal now."
    Target URL: Proposal URL
    Type: Proposals
  • Voting Ended (Voters)
    Trigger: A proposal ended
    Target recipient: Users who voted on the proposal
    Copy: Title: "Voting Ended on a Proposal You Voted On"
    Description: "Discover the results of the proposal you participated in as a voter. Your input matters!"
    Target URL: Proposal URL
    Type: Proposals
  • New Feature/Changelog
    Trigger: Governance Squad released a new feature
    Target recipient: Users of the DAO
    Copy: TBD
    Target URL: Customized by Governance Squad
    Type: Announcements

@yemel yemel temporarily deployed to governance-pr-1233 September 4, 2023 15:00 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 4, 2023 18:39 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 5, 2023 14:01 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 5, 2023 14:08 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 14, 2023 19:15 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 14, 2023 21:16 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 18, 2023 17:29 Inactive
@andyesp andyesp force-pushed the feat/notifications-push branch from 8402af9 to 8ec5694 Compare September 19, 2023 14:26
@andyesp andyesp temporarily deployed to governance-pr-1233 September 19, 2023 14:26 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 19, 2023 17:26 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 20, 2023 00:21 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 20, 2023 01:00 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 20, 2023 16:27 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 September 20, 2023 16:51 Inactive
@andyesp andyesp had a problem deploying to governance-pr-1233 October 6, 2023 19:23 Failure
@andyesp andyesp temporarily deployed to governance-pr-1233 October 6, 2023 19:48 Inactive
@andyesp andyesp had a problem deploying to governance-pr-1233 October 6, 2023 22:18 Failure
src/back/routes/notification.ts Outdated Show resolved Hide resolved
type: 'TEXT',
notNull: true,
},
last_notification_id: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be handy to have the created-at/updated_at for debug purposes.

For example, if at some point the service stop working or whatevs, we could know which where the last updated, or since when it stopped working, etc

@andyesp andyesp temporarily deployed to governance-pr-1233 October 10, 2023 15:04 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 10, 2023 15:51 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 10, 2023 16:11 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 10, 2023 18:13 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 10, 2023 19:02 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 10, 2023 19:21 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 19, 2023 17:10 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 19, 2023 18:03 Inactive
@andyesp andyesp temporarily deployed to governance-pr-1233 October 19, 2023 20:54 Inactive
@andyesp andyesp merged commit f8b3f15 into master Oct 20, 2023
1 check passed
@andyesp andyesp deleted the feat/notifications-push branch October 20, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-app Notifications V1
4 participants