Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: return validated values from validators #1259

Merged
merged 5 commits into from
Sep 14, 2023
Merged

chore: return validated values from validators #1259

merged 5 commits into from
Sep 14, 2023

Conversation

1emu
Copy link
Collaborator

@1emu 1emu commented Sep 14, 2023 •
edited
Loading

Closes #1257

@1emu 1emu requested review from andyesp and ncomerci September 14, 2023 16:22
@yemel yemel temporarily deployed to governance-pr-1259 September 14, 2023 16:22 Inactive
andyesp
andyesp approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@andyesp andyesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@1emu 1emu merged commit cfbd9fd into master Sep 14, 2023
1 check passed
@1emu 1emu deleted the chore/validators-return branch September 14, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncomerci ncomerci ncomerci approved these changes

@andyesp andyesp andyesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve routes validators to return validated parameter when it's not optional
4 participants
@1emu @andyesp @ncomerci @yemel