Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show competing grants only on active ones #1326

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

ncomerci
Copy link
Contributor

@ncomerci ncomerci commented Oct 6, 2023

This closes #1281

@ncomerci ncomerci requested review from 1emu and andyesp October 6, 2023 18:45
Copy link
Collaborator

@1emu 1emu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Ok with the changes, but I'd consider avoiding the render & request at all if the proposal is not active :)

@ncomerci ncomerci force-pushed the fix/1281-competing-grants branch from 1e3e039 to 815c56a Compare October 6, 2023 19:16
@andyesp andyesp merged commit 11705a1 into master Oct 6, 2023
1 check passed
@andyesp andyesp deleted the fix/1281-competing-grants branch October 6, 2023 22:35
1emu pushed a commit that referenced this pull request Oct 17, 2023
* fix: show competing grants only on active ones

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Competing grants are showing in enacted grants
3 participants