Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catalog search ignore limit and offset #359

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

meelrossi
Copy link

When searching for items in the catalog by a search term we should not limit the query that search for ids with specific term as it will cause for some items to be filtered before doing the proper catalog search

before this change
/v1/catalog?first=5&category=wearable&search=m would return only one item as it will only consider the first 5 ids that match the term m to later do the wearable category filter

after this change
/v1/catalog?first=5&category=wearable&search=m will return 5 (with the total being 81)

Copy link
Contributor

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Should we set a default LIMIT at least to avoid having a ton of results in memory if the search term is too vague? Approving anyways because it looks good.

@meelrossi meelrossi merged commit 030cb26 into master Oct 31, 2023
1 check passed
@meelrossi meelrossi deleted the feat/fix-search-catalog branch October 31, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants