-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor did:dht
#68
Merged
Merged
Refactor did:dht
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jiyoon Koo <[email protected]>
Co-Authored-By: Jiyoon Koo <[email protected]> Co-Authored-By: Moe Jangda <[email protected]>
This was
linked to
issues
Apr 24, 2024
Closed
…t into dht-refactor-step-2
mistermoe
requested review from
ethan-tbd,
kirahsapong,
wesbillman and
diehuxx
as code owners
April 25, 2024 00:23
ethan-tbd
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
There's a decent amount of housekeeping that can be done still (variable naming etc.) but will tackle that in subsequent PRs. want to get this out the door!
TODO:
VerificationMethodConverter
to convert verification method <-> txt record & testServiceConverter
to convert service <-> txt record & testDidDocumentConverter
to convert did document <-> dns packet & testDidDht.create
DidDht.resolve
DidDocumentConverter.convertDnsPacket