-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export PEX type directly #336
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2023-12-06T17:16:19Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 92.23% 92.71% +0.47%
==========================================
Files 75 75
Lines 16771 16787 +16
Branches 1567 1575 +8
==========================================
+ Hits 15469 15564 +95
+ Misses 1276 1197 -79
Partials 26 26
|
I dont understand why typescript is doing this.. Chad says we can also try this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible can we try this first? As it will look -more- uniform for the rest of the code.
export interface PresentationDefinitionV2 extends PexPresDefV2 { }
and in the future we may change all exports to look like this
* Export pex type directly * Extend and export sphereon type
* Export pex type directly * Extend and export sphereon type
* Export pex type directly * Extend and export sphereon type
This PR exports the sphereon
PresentationDefinitionV2
type directly, instead of a type alias, to resolve a TS issue inferring the type in consuming packages, wherexyz
should be of typePresentationDefinitionV2
:See here for further discussion