Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output flag to send output to file #404

Merged

Conversation

w3irdrobot
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR adds a global flag called output that, when present, is a path to a file to create and send all output to instead of stdout.

Related Tickets & Documents

Resolves #387

Mobile & Desktop Screenshots/Recordings

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • [] 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

No

[optional] What gif best describes this PR or how it makes you feel?

image

@w3irdrobot w3irdrobot force-pushed the issue-387-add-output-flag branch from 2a09c2f to 48d4ffe Compare October 29, 2024 14:14
@KendallWeihe
Copy link
Contributor

@w3irdrobot are you able to resolve merge conflicts?

@w3irdrobot w3irdrobot force-pushed the issue-387-add-output-flag branch from 48d4ffe to 7e24fc2 Compare October 29, 2024 14:35
@w3irdrobot
Copy link
Contributor Author

@KendallWeihe done

Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@KendallWeihe KendallWeihe merged commit 95c9cda into decentralized-identity:main Oct 29, 2024
26 checks passed
@w3irdrobot
Copy link
Contributor Author

@blackgirlbytes it appears this PR wasn't given the hacktoberfest-accepted label and isn't being shown on the leaderboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement mktemp functionality in Web5 CLI
2 participants