-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyodide to 0.17 and fix js adapter #308
Conversation
…yodide-17 # Conflicts: # Dockerfile # Dockerfile.release # bulletin_board/server/db/seeds.rb # voting_schemes/electionguard/docker/pyodide-electionguard/Dockerfile # voting_schemes/electionguard/docker/pyodide-electionguard/packages/libgmp/Makefile # voting_schemes/electionguard/docker/pyodide-electionguard/packages/libgmp/checksums # voting_schemes/electionguard/python-to-js/build # voting_schemes/electionguard/python-wrapper/Pipfile.lock # voting_schemes/electionguard/python-wrapper/integration_results.jsonl # voting_schemes/electionguard/python-wrapper/src/bulletin_board/electionguard/trustee.py # voting_schemes/electionguard/python-wrapper/tests/test_integration.py
Codecov Report
@@ Coverage Diff @@
## develop #308 +/- ##
========================================
Coverage 69.57% 69.57%
========================================
Files 96 96
Lines 1630 1630
========================================
Hits 1134 1134
Misses 496 496 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions, but generally is looking good 😄
voting_schemes/electionguard/python-wrapper/src/bulletin_board/electionguard/bulletin_board.py
Outdated
Show resolved
Hide resolved
voting_schemes/electionguard/docker/pyodide-electionguard/packages/libgmp/Makefile
Outdated
Show resolved
Hide resolved
@andreslucena what you say, can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
This PR makes the JS client, server and pyodide adapters work again.
Note:
After this PR is merge I'll update #309 to the next version number, test it on the decidim PR upgrade branch (decidim/decidim#11711). When everything green we can release the final version