-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document README files #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, I only have a few minor details and this is ready
Changes applied @andreslucena |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more details and we're good
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #312 +/- ##
========================================
Coverage 69.57% 69.57%
========================================
Files 96 96
Lines 1630 1630
========================================
Hits 1134 1134
Misses 496 496 ☔ View full report in Codecov by Sentry. |
There's a failing spec for a linter but that's already happening in the |
Document readmes for the included gems.
fixes #246