-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron: Update to 27.0.3. #3927
Conversation
Tested on windows, linux and macOS. On macOS it worked fine. On Windows the On Linux, DEX did not open, and downgrading to 26.4.3 also did not make it work (neither in testnet nor mainnet). Still trying to work out why or which version is able to run it. |
@matheusd That was what I encountered as well. I was able to narrow it down to something in https://github.com/electron/electron/releases/tag/v21.3.0 that was causing it to not work on Linux anymore. Hence why I rolled back to 21.2.3. Afaict that's the last working version of electron. And the only change in there that could possibly have a difference is a Chromium update. |
While debugging I set the dex window to openDevTools and I get an error there. That may or may not be the issue. I'm retesting on master and then will test on 21.3.0 to see if that's the issue |
I expect something in chromium broke a lib that the dex interface uses on linux. |
I believe this is the issue:
More precisely, passing We'll probably need to check with the DEX UI ppl how to fix this |
@matheusd Shall I make this upgrade to 26.4.3? That also solves the main ledger issue. |
Yes please. This should fix the windows build, though there's still the issue of the DEX UI failing on linux. |
Closing this one in favor of another that includes the dcrdex fix as well. |
closes #3921