Skip to content

Commit

Permalink
Update dependencies (#3)
Browse files Browse the repository at this point in the history
* Refresh pinned dependencies

This is just the result of running:

    npm update

In particular, this updates @actions/core to a version new enough to use
environment files for output rather than stdout. Without this, the
following method call:

    core.setOutput('id', assetEditId)

results in the following warning:

> Warning: The `set-output` command is deprecated and will be disabled
> soon. Please upgrade to using Environment Files. For more information
> see:
> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* Update axios 1.7.2

This addresses a warning that the previously-pinned version was affected
by GHSA-wf5p-g6vw-rhxx.

* Update @actions/github to 6.0.0

This fixes the following warning issued by node.js due to one of the
package's transitive dependencies:

    (node:243) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
        at node:punycode:3:9
        at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
        at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10)
        at loadBuiltinModule (node:internal/modules/helpers:96:7)
        at Module._load (node:internal/modules/cjs/loader:1063:17)
        at wrapModuleLoad (node:internal/modules/cjs/loader:212:19)
        at Module.require (node:internal/modules/cjs/loader:1297:12)
        at require (node:internal/modules/helpers:123:16)
        at Object.<anonymous> (/sysroot/home/wjt/src/deep-entertainment/godot-asset-lib-action/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
        at Module._compile (node:internal/modules/cjs/loader:1460:14)

* Update prettier to 3.3.2

* Update @vercel/ncc to 0.38.1+

* Add command to format source files with prettier

* Format source files with prettier

* Run action against node20 runtime

node12 is no longer supported by GitHub Actions; since summer 2023
actions have been run against node16 instead.

node20 is the latest supported version.

Run both the action, and the workflow which checks that the generated
code is up to date, against node20.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

* Update prettier to 3.3.3

* Update generated code
  • Loading branch information
wjt authored Jul 24, 2024
1 parent 656fe24 commit 056fa40
Show file tree
Hide file tree
Showing 7 changed files with 42,581 additions and 12,737 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
id: setup-node
uses: actions/setup-node@v4
with:
node-version: '12.x'
node-version: '20.x'
cache: npm

- name: Install Dependencies
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ outputs:
id:
description: 'The id of the asset edit'
runs:
using: 'node12'
using: 'node20'
main: 'dist/index.js'
8 changes: 4 additions & 4 deletions commands/addEdit.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ module.exports = class extends Command {
const assetEdit = JSON.parse(template(context))
console.log(
`Sending request: ${JSON.stringify(
assetEdit
)} (token redacted) to url ${baseUrl}/asset/${assetId}`
assetEdit,
)} (token redacted) to url ${baseUrl}/asset/${assetId}`,
)
assetEdit.token = this._token
const res = await axios.post(`${baseUrl}/asset/${assetId}`, assetEdit)
Expand All @@ -37,14 +37,14 @@ module.exports = class extends Command {
`${baseUrl}/asset/edit/${assetEditId}/review`,
{
token: this._token,
}
},
)
console.log('Accepting the edit')
const resAccept = await axios.post(
`${baseUrl}/asset/edit/${assetEditId}/accept`,
{
token: this._token,
}
},
)
}

Expand Down
Loading

0 comments on commit 056fa40

Please sign in to comment.