Fix memory leak

Any time a new client connects, it is added to the _clients array and never removed until the server stops. This fix removes disconnected clients from the list after processing each frame.
deep-entertainment · Oct 21, 2024 · 6825e55 · 6825e55
1 parent 12ca995
commit 6825e55
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/addons/godottpd/http_server.gd b/addons/godottpd/http_server.gd
@@ -92,6 +92,11 @@ func _process(_delta: float) -> void:
 				if bytes > 0:
 					var request_string = client.get_utf8_string(bytes)
 					self._handle_request(client, request_string)
+		_remove_disconnected_clients()
+
+
+func _remove_disconnected_clients():
+	self._clients = self._clients.filter(func(c: StreamPeerTCP): c.get_status() == StreamPeerTCP.STATUS_CONNECTED)
 
 
 # Start the server