Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Render Lists #1061
base: main
Are you sure you want to change the base?
docs: Render Lists #1061
Changes from 4 commits
8611541
e06403b
3e5b482
c57c36c
79d41e0
bd3ea49
33a88de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing talking about the
key
prop here. Each value in the list should have a key, and the React docs go into explicitly: https://react.dev/learn/rendering-lists#why-does-react-need-keysIn terms of deephaven.ui, it can be observed why you need keys when running a todo app. See an example without keys: #731
If you comment out the
key=str(i)
line, you'll see it screws up if you delete any of the cells except the last one; it will always "delete" the last cell:By adding the key, it knows how to track the elements and delete the correct one.
Should also write it with list comprehension, and possibly refactor the child todo component into a
ui_deletable_cell
or something.