-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commit SHA to branch / edge images #114
Comments
This feature could also be considered more widely solved via deephaven/deephaven-core#3705; that said, there is still room for us to add deephaven-server-docker build sourced information, even if the above issue is completed. |
Are you thinking of something like the following idea for the interim?
Or That would mean it's captured in the image, but it would not be reachable in a native build. |
Here's an example to set the deephaven-core commit hash to an environment variable in the docker image. https://github.com/deephaven/deephaven-server-docker/compare/main...stanbrub:deephaven-server-docker:commit-hash-in-image?expand=1. Not complete but shows something working. |
Yes, something like that. I think we want to ultimately propagate it into the LABEL field. I would have hoped that the checkout action had an official output, but it looks like it doesn't (although, it seems like a pretty popular feature request, actions/checkout#209). |
|
This is similar to #46, but specifically focused on adding commit SHA details to branch / edge images. We should be able to capture environment / checkout details for these branch / edge workflows and pass through those details into the image.
The text was updated successfully, but these errors were encountered: