Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed issue with placeholder connection being removed too early #189

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Dec 5, 2024

Placeholder urls were being removed before real connection was ready resulting in connections temporarily disappearing from the UI. This should fix that.

DH-18119

@bmingles bmingles requested a review from mofojed December 5, 2024 16:53
Copy link

github-actions bot commented Dec 5, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:54:10
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1791
should return custom settings: Empty configspassed ✅274
should return custom settings: Populated configspassed ✅108
should be able to load VSCodepassed ✅1133
should only be visible when a supported file type is active: test.groovypassed ✅2746
should only be visible when a supported file type is active: test.pypassed ✅1013
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles merged commit ea366ed into main Dec 6, 2024
3 checks passed
@bmingles bmingles deleted the DH-18119_fix-disappearing-worker-connection branch December 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants