Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added PanelRegistry so panels can be re-used globally #24

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Jul 8, 2024

Panels are now stored in a global registry instead of being scoped to DhcService instance. This allows re-use of panels after re-connecting.

Testing

  • Run a script
  • Restart the server
  • Re-run the script. Should re-use the open panel

resolves #3

@bmingles bmingles marked this pull request as ready for review July 8, 2024 18:10
@bmingles bmingles requested a review from mofojed July 10, 2024 16:13
@bmingles bmingles merged commit f86f4f1 into main Jul 10, 2024
4 checks passed
@bmingles bmingles deleted the 3-reuse-panels branch July 10, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old Widgets Do Not Get Cleaned Up or Reused
2 participants