Skip to content

Commit

Permalink
[docs] Updates documents to use JDK 17 (#2898)
Browse files Browse the repository at this point in the history
  • Loading branch information
frankfliu authored Dec 20, 2023
1 parent 6708a42 commit 1060bdd
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion apt.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
openjdk-11-jdk
openjdk-17-jdk
14 changes: 7 additions & 7 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@ docker build --build-arg version=<YOUR_VERSION>

You can use the [docker file](https://github.com/deepjavalibrary/djl/blob/master/docker/tensorrt/Dockerfile) provided by us.
This docker file is a modification of the one provided by NVIDIA in
[TensorRT](https://github.com/NVIDIA/TensorRT/blob/8.4.1/docker/ubuntu-18.04.Dockerfile) to include JDK11.
By default this sets up a container using Ubuntu 18.04 and CUDA 11.6.2. You can build the container with other versions as follows,
[TensorRT](https://github.com/NVIDIA/TensorRT/blob/8.4.1/docker/ubuntu-18.04.Dockerfile) to include JDK17.
By default this sets up a container using Ubuntu 18.04 and CUDA 11.6.2. You can build the container with other versions as follows,
but keep in mind the TensorRT software requirements outlined [here](https://github.com/NVIDIA/TensorRT#prerequisites):

```bash
docker build --build-arg OS_VERSION=<YOUR_VERSION> --build-arg CUDA_VERSION=<YOUR_VERSION>
```

To run the container, we recommend using `nvidia-docker run ...` to ensure cuda driver and runtime are compatible.
To run the container, we recommend using `nvidia-docker run ...` to ensure cuda driver and runtime are compatible.

We recommend that you follow the setup steps in the [TensorRT guide](https://github.com/NVIDIA/TensorRT) if you
need access to the full suite of tools TensorRT provides, such as `trtexec` which can convert onnx models to
uff tensorrt models. When following that guide, make sure to use the DJL provided
[docker file](https://github.com/deepjavalibrary/djl/blob/master/docker/tensorrt/Dockerfile) to enable JDK11 in the docker container.
We recommend that you follow the setup steps in the [TensorRT guide](https://github.com/NVIDIA/TensorRT) if you
need access to the full suite of tools TensorRT provides, such as `trtexec` which can convert onnx models to
uff tensorrt models. When following that guide, make sure to use the DJL provided
[docker file](https://github.com/deepjavalibrary/djl/blob/master/docker/tensorrt/Dockerfile) to enable JDK17 in the docker container.
2 changes: 1 addition & 1 deletion docker/tensorrt/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
fakeroot \
dh-make \
build-essential \
openjdk-11-jdk && \
openjdk-17-jdk && \
apt-get clean -y && rm -rf /var/lib/apt/lists/*

# Install python3
Expand Down
2 changes: 1 addition & 1 deletion docker/windows/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ RUN powershell -Command \
Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1')); \
choco feature disable --name showDownloadProgress

RUN choco install -y openjdk11
RUN choco install -y openjdk17
6 changes: 3 additions & 3 deletions docs/development/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ you can use the $JAVA_HOME environment variable to control which version of Java
For ubuntu:

```bash
sudo apt-get install openjdk-11-jdk
sudo apt-get install openjdk-17-jdk
```

For centos

```bash
sudo yum install java-11-openjdk
sudo yum install java-17-openjdk
```

For Mac:

```bash
brew tap homebrew/cask-versions
brew update
brew install --cask temurin11
brew install --cask zulu17
```

You can also download and install [Oracle JDK](https://www.oracle.com/technetwork/java/javase/overview/index.html)
Expand Down

0 comments on commit 1060bdd

Please sign in to comment.